[Linuxptp-devel] honor DESTDIR in install-target

[z***@iem.at]

Another issue that arose while packaging linuxptp for Debian was,
that the 'install' target in the makefile completely ignored the
DESTDIR variable, that allows to install into a staging directory¹.

I added a patch that prefixes all installation paths with $(DESTDIR).
While being there, I also replaced the call to 'mkdir' with a more
standard call to 'install -d'.

Thanks for consideration,

gfmasrd
IOhannes

PS: if this comes in double, please accept my apologies. my mail spool
went out of disk space.

¹ https://www.gnu.org/prep/standards/html_node/DESTDIR.html

------------------------------------------------------------------------------

[z***@iem.at]

From: IOhannes m zmölnig <***@umlautQ.umlaeute.mur.at>

and use 'install' throughout (rather than 'mkdir')
---
makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/makefile b/makefile
index ca82f5e..0f22b16 100644
--- a/makefile
+++ b/makefile
@@ -69,9 +69,9 @@ version.o: .version version.sh $(filter-out version.d,$(DEPEND))
force:

install: $(PRG)
- mkdir -p $(sbindir) $(man8dir)
- install $(PRG) $(sbindir)
- install -p -m 644 -t $(man8dir) $(PRG:%=%.8)
+ install -p -m 755 -d $(DESTDIR)$(sbindir) $(DESTDIR)$(man8dir)
+ install $(PRG) $(DESTDIR)$(sbindir)
+ install -p -m 644 -t $(DESTDIR)$(man8dir) $(PRG:%=%.8)

clean:
rm -f $(OBJECTS) $(DEPEND)

[Richard Cochran]

Before I can apply this patch and the two others, I need to have the
patches "signed off by" yourself. That means adding a one line tag
into the patch description that looks like this:

Signed-off-by: Richard Cochran <***@gmail.com>

That tag tells us that you can contribute under the conditions found
in Documentation/SubmittingPatches from the Linux kernel.

Maybe you think it is a silly formality, I think it is important to
make sure that we have a basic, common understanding about the GPL
licensing of the linuxptp software.

Thanks,
Richard

------------------------------------------------------------------------------

[IOhannes m zmoelnig]

Post by Richard Cochran
Before I can apply this patch and the two others, I need to have the
patches "signed off by" yourself.

[...]

Post by Richard Cochran
Maybe you think it is a silly formality, I think it is important to
make sure that we have a basic, common understanding about the GPL
licensing of the linuxptp software.

thanks for the feedback.

i don't think it a silly formality at all.
however, i do think this ought to be documented.

if i had known, i might have sent the correct patches to the correct
email address in a first attempt, rather than having to go through them
again and again.

preferrably, it would be documented in the README (or a CONTRIBUTING)
file within the linuxptp tree, rather than referring to some external
documentation (even if you consider the - say - kernel style guide to be
the canonical reference for such things).

gmfasdrt
IOhannes

[z***@iem.at]

in order to not only complain about missing documentation,
i decided to jfdi :-)

fgmadsr
IOhannes


------------------------------------------------------------------------------

[z***@iem.at]

From: IOhannes m zmölnig <***@umlautQ.umlaeute.mur.at>

Make the workflow of contribution (creating patches, submitting,
reviewing) explicit.

Signed-off-by: IOhannes m zmölnig <***@umlaeute.mur.at>
---
README.org | 34 ++++++++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)

diff --git a/README.org b/README.org
index 742cbf4..aaad3c5 100644
--- a/README.org
+++ b/README.org
@@ -245,6 +245,40 @@

https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

+*** Submitting Patches
+
+ 1. Before submitting patches, please make sure that you are starting
+ your work on the *current HEAD* of the git repository.
+
+ 2. Please checkout the ~CODING_STYLE.org~ file for guidelines on how to
+ properly format your code.
+
+ 3. Describe your changes. Each patch will be reviewed, and the reviewers
+ need to understand why you did what you did.
+
+ 4. *Sign-Off* each commit, so the changes can be properly attributed to
+ you and you explicitely give your agreement for distribution under
+ linuxptp's license. Signing-off is as simple as:
+
+ #+BEGIN_EXAMPLE
+ git commit -s
+ #+END_EXAMPLE
+
+ or by adding the following line (replace your real name and email)
+ to your patch:
+
+ #+BEGIN_EXAMPLE
+ Signed-off-by: Random J Developer <***@developer.example.org>
+ #+END_EXAMPLE
+
+ 5. Finally, send your patches via email to the linuxptp-devel mailing
+ list, where they will be reviewed, and eventually be included in the
+ official code base.
+
+ #+BEGIN_EXAMPLE
+ git send-email --to linuxptp-***@lists.sourceforge.net origin/master
+ #+END_EXAMPLE
+
* Thanks

Thanks to AudioScience Inc for sponsoring the 8021.AS support.

[Richard Cochran]

Post by z***@iem.at
Make the workflow of contribution (creating patches, submitting,
reviewing) explicit.

Applied.

Thanks,
Richard


------------------------------------------------------------------------------