[Linuxptp-devel] [PATCH v1] ptp4l: use ethtool operation to double check PHC

[Jacob Keller]

If the new ethtool operation is supported, then use it to verify that the PHC
selected by the user is correct. If the user doesn't specify a PHC and ethtool
is supported then automatically select the PHC device.

If the user specifies a PHC device, and the ethtool operation is suppported,
automatically confirm that the PHC device requested is correct. This check is
performed for all ports, in order to verify that a boundary clock setup is
valid.

The check for PHC device validity is not done in the transport because the
only thing necessary for performing the check is the port name. Handled this
in the port_open code instead.

Signed-off-by: Jacob Keller <***@intel.com>
---
clock.c | 8 +++++---
clock.h | 4 ++--
port.c | 13 +++++++++++++
port.h | 1 +
ptp4l.c | 26 ++++++++++++++++++++------
sk.c | 36 ++++++++++++++++++++++++++++++++++++
sk.h | 7 +++++++
7 files changed, 84 insertions(+), 11 deletions(-)

diff --git a/clock.c b/clock.c
index 9a21ecf..742099b 100644
--- a/clock.c
+++ b/clock.c
@@ -174,18 +174,20 @@ UInteger8 clock_class(struct clock *c)
return c->dds.clockQuality.clockClass;
}

-struct clock *clock_create(char *phc, struct interface *iface, int count,
+struct clock *clock_create(int phc_index, struct interface *iface, int count,
struct defaultDS *ds, struct port_defaults *pod)
{
int i, max_adj, sw_ts = 0;
struct clock *c = &the_clock;
+ char phc[32];

srandom(time(NULL));

if (c->nports)
clock_destroy(c);

- if (phc) {
+ if (phc_index >= 0) {
+ snprintf(phc, 31, "/dev/ptp%d", phc_index);
c->clkid = phc_open(phc);
if (c->clkid == CLOCK_INVALID) {
pr_err("Failed to open %s: %m", phc);
@@ -235,7 +237,7 @@ struct clock *clock_create(char *phc, struct interface *iface, int count,
c->fault_timeout = FAULT_RESET_SECONDS;

for (i = 0; i < count; i++) {
- c->port[i] = port_open(pod, iface[i].name, iface[i].transport,
+ c->port[i] = port_open(pod, phc_index, iface[i].name, iface[i].transport,
iface[i].timestamping, 1+i, iface[i].dm, c);
if (!c->port[i]) {
pr_err("failed to open port %s", iface[i].name);
diff --git a/clock.h b/clock.h
index 825f438..dd1950d 100644
--- a/clock.h
+++ b/clock.h
@@ -67,14 +67,14 @@ UInteger8 clock_class(struct clock *c);
* so subsequent calls will destroy the previous clock instance.
*
* @param phc PTP hardware clock device to use.
- * Pass NULL to select CLOCK_REALTIME.
+ * Pass -1 to select CLOCK_REALTIME.
* @param interface An array of network interfaces.
* @param count The number of elements in @a interfaces.
* @param ds A pointer to a default data set for the clock.
* @param pod A pointer to a default port data set for the clock.
* @return A pointer to the single global clock instance.
*/
-struct clock *clock_create(char *phc, struct interface *iface, int count,
+struct clock *clock_create(int phc_index, struct interface *iface, int count,
struct defaultDS *ds, struct port_defaults *pod);

/**
diff --git a/port.c b/port.c
index ebcc7bb..1ef2fca 100644
--- a/port.c
+++ b/port.c
@@ -33,6 +33,7 @@
#include "tmtab.h"
#include "tmv.h"
#include "util.h"
+#include "sk.h"

#define PORT_MAVE_LENGTH 10

@@ -1328,6 +1329,7 @@ enum fsm_event port_event(struct port *p, int fd_index)
}

struct port *port_open(struct port_defaults *pod,
+ int phc_index,
char *name,
enum transport_type transport,
enum timestamp_type timestamping,
@@ -1336,11 +1338,22 @@ struct port *port_open(struct port_defaults *pod,
struct clock *clock)
{
struct port *p = malloc(sizeof(*p));
+ int checked_phc_index = -1;
+
if (!p)
return NULL;

memset(p, 0, sizeof(*p));

+ if (sk_interface_phc(name, &checked_phc_index))
+ pr_warning("get_ts_info operation not supported");
+ else if ((phc_index >= 0) && (phc_index != checked_phc_index)) {
+ pr_err("requested and expected phc devices don't match");
+ pr_err("/dev/ptp%d requested, but /dev/ptp%d expected",
+ phc_index, checked_phc_index);
+ return NULL;
+ }
+
p->pod = *pod;
p->name = name;
p->clock = clock;
diff --git a/port.h b/port.h
index 6f02b73..7ecd893 100644
--- a/port.h
+++ b/port.h
@@ -89,6 +89,7 @@ enum fsm_event port_event(struct port *port, int fd_index);
* @return A pointer to an open port on success, or NULL otherwise.
*/
struct port *port_open(struct port_defaults *pod,
+ int phc_index,
char *name,
enum transport_type transport,
enum timestamp_type timestamping,
diff --git a/ptp4l.c b/ptp4l.c
index cbf0d7e..b645636 100644
--- a/ptp4l.c
+++ b/ptp4l.c
@@ -77,23 +77,24 @@ static void usage(char *progname)
" (may be specified multiple times)\n"
" -l [num] set the logging level to 'num'\n"
" -m slave only mode (overrides configuration file)\n"
- " -p [dev] PTP hardware clock device to use, default '%s'\n"
+ " -p [dev] PTP hardware clock device to use, default auto\n"
" (ignored for SOFTWARE/LEGACY HW time stamping)\n"
" -q quiet mode, do not use syslog(3)\n"
" -v verbose mode, print messages to stdout\n"
"\n",
- progname, DEFAULT_PHC);
+ progname);
}

int main(int argc, char *argv[])
{
- char *config = NULL, *phc = DEFAULT_PHC, *progname;
+ char *config = NULL, *req_phc = NULL, *progname;
int c, i, nports = 0, slaveonly = 0;
struct interface iface[MAX_PORTS];
enum delay_mechanism dm = DM_E2E;
enum transport_type transport = TRANS_UDP_IPV4;
enum timestamp_type timestamping = TS_HARDWARE;
struct clock *clock;
+ int phc_index = -1;

/* Process the command line arguments. */
progname = strrchr(argv[0], '/');
@@ -139,7 +140,7 @@ int main(int argc, char *argv[])
dm = DM_P2P;
break;
case 'p':
- phc = optarg;
+ req_phc = optarg;
break;
case 'q':
print_no_syslog();
@@ -176,8 +177,21 @@ int main(int argc, char *argv[])
for (i = 0; i < nports; i++) {
iface[i].timestamping = timestamping;
}
+
+ /* determine PHC Clock index */
if (timestamping == TS_SOFTWARE || timestamping == TS_LEGACY_HW) {
- phc = NULL;
+ phc_index = -1;
+ } else if (req_phc) {
+ sscanf(req_phc, "/dev/ptp%d", &phc_index);
+ } else if (sk_interface_phc(iface[0].name, &phc_index)) {
+ fprintf(stderr, "get_ts_info operation not supported\n"
+ "please specify PHC device\n");
+ return -1;
+ }
+
+ if (phc_index >= 0) {
+ fprintf(stderr, "selected /dev/ptp%d as PHC clock\n",
+ phc_index);
}

ds.slaveOnly = FALSE;
@@ -213,7 +227,7 @@ int main(int argc, char *argv[])
ds.clockQuality.clockClass = 255;
}

- clock = clock_create(phc, iface, nports, &ds, &pod);
+ clock = clock_create(phc_index, iface, nports, &ds, &pod);
if (!clock) {
fprintf(stderr, "failed to create a clock\n");
return -1;
diff --git a/sk.c b/sk.c
index 810d036..e7d2fbe 100644
--- a/sk.c
+++ b/sk.c
@@ -20,6 +20,7 @@
#include <errno.h>
#include <linux/net_tstamp.h>
#include <linux/sockios.h>
+#include <linux/ethtool.h>
#include <net/if.h>
#include <netinet/in.h>
#include <string.h>
@@ -29,6 +30,10 @@
#include "print.h"
#include "sk.h"

+#ifndef SIOCETHTOOL
+#define SIOCETHTOOL 0x8946
+#endif
+
/* private methods */

static int hwts_init(int fd, char *device)
@@ -83,6 +88,37 @@ int sk_interface_index(int fd, char *name)
return ifreq.ifr_ifindex;
}

+int sk_interface_phc(char *name, int *index)
+{
+ struct ethtool_ts_info info;
+ struct ifreq ifr;
+ int fd, err;
+
+ memset(&ifr, 0, sizeof(ifr));
+ memset(&info, 0, sizeof(info));
+ info.cmd = ETHTOOL_GET_TS_INFO;
+ strcpy(ifr.ifr_name, name);
+ ifr.ifr_data = &info;
+ fd = socket(AF_INET, SOCK_DGRAM, 0);
+
+ if (fd < 0) {
+ pr_err("socket failed: %m");
+ return -1;
+ }
+
+ err = ioctl(fd, SIOCETHTOOL, &ifr);
+ if (err < 0) {
+ pr_err("ioctl SIOCETHTOOL failed: %m");
+ close(fd);
+ return -1;
+ }
+
+ close(fd);
+ *index = info.phc_index;
+
+ return 0;
+}
+
int sk_interface_macaddr(char *name, unsigned char *mac, int len)
{
struct ifreq ifreq;
diff --git a/sk.h b/sk.h
index 78f1085..14ade94 100644
--- a/sk.h
+++ b/sk.h
@@ -31,6 +31,13 @@
int sk_interface_index(int fd, char *device);

/**
+ * Obtain the PHC device index of a network interface.
+ * @param name The name of the interface
+ * @return index The phc index associated with this iface
+ */
+int sk_interface_phc(char *name, int *index);
+
+/**
* Obtain the MAC address of a network interface.
* @param name The name of the interface
* @param mac Buffer to hold the result

[Richard Cochran]

Jacob,

Thanks for this patch. Could I bother you to make a few changes?
Most of my comments are just nit picking, a few are more substantial.

Post by Jacob Keller
diff --git a/clock.h b/clock.h
index 825f438..dd1950d 100644
--- a/clock.h
+++ b/clock.h
@@ -67,14 +67,14 @@ UInteger8 clock_class(struct clock *c);
* so subsequent calls will destroy the previous clock instance.
*

Also need:
@param phc_index PTP hardware clock device to use.

Post by Jacob Keller
- * Pass NULL to select CLOCK_REALTIME.
+ * Pass -1 to select CLOCK_REALTIME.
*/
-struct clock *clock_create(char *phc, struct interface *iface, int count,
+struct clock *clock_create(int phc_index, struct interface *iface, int count,
struct defaultDS *ds, struct port_defaults *pod);
/**
diff --git a/port.c b/port.c
index ebcc7bb..1ef2fca 100644
--- a/port.c
+++ b/port.c
@@ -33,6 +33,7 @@
#include "tmtab.h"
#include "tmv.h"
#include "util.h"
+#include "sk.h"
#define PORT_MAVE_LENGTH 10
@@ -1328,6 +1329,7 @@ enum fsm_event port_event(struct port *p, int fd_index)
}
struct port *port_open(struct port_defaults *pod,
+ int phc_index,
char *name,
enum transport_type transport,
enum timestamp_type timestamping,
@@ -1336,11 +1338,22 @@ struct port *port_open(struct port_defaults *pod,
struct clock *clock)
{
struct port *p = malloc(sizeof(*p));
+ int checked_phc_index = -1;
+
if (!p)
return NULL;
memset(p, 0, sizeof(*p));
+ if (sk_interface_phc(name, &checked_phc_index))
+ pr_warning("get_ts_info operation not supported");

I would like to have the port number in this message, like so:

pr_warning("port %d: get_ts_info operation not supported", number);

Post by Jacob Keller
+ else if ((phc_index >= 0) && (phc_index != checked_phc_index)) {

Too many parentheses here.

Post by Jacob Keller
+ pr_err("requested and expected phc devices don't match");
+ pr_err("/dev/ptp%d requested, but /dev/ptp%d expected",
+ phc_index, checked_phc_index);

To me, saying 'expected' is confusing. How about this instead?

else if (phc_index >= 0 && phc_index != checked_phc_index) {
pr_err("port %d: PHC device mismatch", number);
pr_err("port %d: /dev/ptp%d requested, but /dev/ptp%d is attached",
number, phc_index, checked_phc_index);

Post by Jacob Keller
+ return NULL;
+ }
+
p->pod = *pod;
p->name = name;
p->clock = clock;
diff --git a/port.h b/port.h
index 6f02b73..7ecd893 100644
--- a/port.h
+++ b/port.h
@@ -89,6 +89,7 @@ enum fsm_event port_event(struct port *port, int fd_index);
*/
struct port *port_open(struct port_defaults *pod,
+ int phc_index,

This new parameter should also be added to the doxygen comment.

Post by Jacob Keller
char *name,
enum transport_type transport,
enum timestamp_type timestamping,
diff --git a/ptp4l.c b/ptp4l.c
index cbf0d7e..b645636 100644
--- a/ptp4l.c
+++ b/ptp4l.c
@@ -77,23 +77,24 @@ static void usage(char *progname)
" (may be specified multiple times)\n"
" -l [num] set the logging level to 'num'\n"
" -m slave only mode (overrides configuration file)\n"
- " -p [dev] PTP hardware clock device to use, default '%s'\n"
+ " -p [dev] PTP hardware clock device to use, default auto\n"
" (ignored for SOFTWARE/LEGACY HW time stamping)\n"
" -q quiet mode, do not use syslog(3)\n"
" -v verbose mode, print messages to stdout\n"
"\n",
- progname, DEFAULT_PHC);
+ progname);
}
int main(int argc, char *argv[])
{
- char *config = NULL, *phc = DEFAULT_PHC, *progname;
+ char *config = NULL, *req_phc = NULL, *progname;
int c, i, nports = 0, slaveonly = 0;
struct interface iface[MAX_PORTS];
enum delay_mechanism dm = DM_E2E;
enum transport_type transport = TRANS_UDP_IPV4;
enum timestamp_type timestamping = TS_HARDWARE;
struct clock *clock;
+ int phc_index = -1;
/* Process the command line arguments. */
progname = strrchr(argv[0], '/');
@@ -139,7 +140,7 @@ int main(int argc, char *argv[])
dm = DM_P2P;
break;
- phc = optarg;
+ req_phc = optarg;
break;
print_no_syslog();
@@ -176,8 +177,21 @@ int main(int argc, char *argv[])
for (i = 0; i < nports; i++) {
iface[i].timestamping = timestamping;
}
+
+ /* determine PHC Clock index */
if (timestamping == TS_SOFTWARE || timestamping == TS_LEGACY_HW) {
- phc = NULL;
+ phc_index = -1;
+ } else if (req_phc) {
+ sscanf(req_phc, "/dev/ptp%d", &phc_index);

Here I would like to see some error checking, like:

if (1 != sscanf(req_phc, "/dev/ptp%d", &phc_index)) {
fprintf(stderr, "bad device string\n");
return -1;
}

Post by Jacob Keller
+ } else if (sk_interface_phc(iface[0].name, &phc_index)) {
+ fprintf(stderr, "get_ts_info operation not supported\n"
+ "please specify PHC device\n");
+ return -1;
+ }
+
+ if (phc_index >= 0) {
+ fprintf(stderr, "selected /dev/ptp%d as PHC clock\n",
+ phc_index);

This isn't really an error message. Please remove this. Instead, how
about a similar message telling the PHC index and network device in
sk_interface_phc(), and using use pr_info so that the message goes
into the log.

Post by Jacob Keller
}
ds.slaveOnly = FALSE;
@@ -213,7 +227,7 @@ int main(int argc, char *argv[])
ds.clockQuality.clockClass = 255;
}
- clock = clock_create(phc, iface, nports, &ds, &pod);
+ clock = clock_create(phc_index, iface, nports, &ds, &pod);
if (!clock) {
fprintf(stderr, "failed to create a clock\n");
return -1;
diff --git a/sk.c b/sk.c
index 810d036..e7d2fbe 100644
--- a/sk.c
+++ b/sk.c
@@ -20,6 +20,7 @@
#include <errno.h>
#include <linux/net_tstamp.h>
#include <linux/sockios.h>
+#include <linux/ethtool.h>
#include <net/if.h>
#include <netinet/in.h>
#include <string.h>
@@ -29,6 +30,10 @@
#include "print.h"
#include "sk.h"
+#ifndef SIOCETHTOOL
+#define SIOCETHTOOL 0x8946
+#endif
+

I don't think this is needed. Why did you add it?

Post by Jacob Keller
/* private methods */
static int hwts_init(int fd, char *device)
@@ -83,6 +88,37 @@ int sk_interface_index(int fd, char *name)
return ifreq.ifr_ifindex;
}
+int sk_interface_phc(char *name, int *index)
+{

This function will not compile using an older (eg 3.0 or 3.1) kernel.
This can be fixed by sandwitching the function body in:

#ifdef ETHTOOL_GET_TS_INFO
...
#else
return -1;
#endif

Post by Jacob Keller
+ struct ethtool_ts_info info;
+ struct ifreq ifr;
+ int fd, err;
+
+ memset(&ifr, 0, sizeof(ifr));
+ memset(&info, 0, sizeof(info));
+ info.cmd = ETHTOOL_GET_TS_INFO;
+ strcpy(ifr.ifr_name, name);
+ ifr.ifr_data = &info;

Need a cast to make gcc 4.4.6 happy.

ifr.ifr_data = (char *) &info;

Thanks,
Richard

[Keller, Jacob E]

Comments inline :)

-----Original Message-----
Sent: Wednesday, May 09, 2012 10:06 AM
To: Keller, Jacob E
Subject: Re: [Linuxptp-devel] [PATCH v1] ptp4l: use ethtool operation to
double check PHC
Jacob,
Thanks for this patch. Could I bother you to make a few changes?
Most of my comments are just nit picking, a few are more substantial.

Post by Jacob Keller
diff --git a/clock.h b/clock.h
index 825f438..dd1950d 100644
--- a/clock.h
+++ b/clock.h
@@ -67,14 +67,14 @@ UInteger8 clock_class(struct clock *c);
* so subsequent calls will destroy the previous clock instance.
*

@param phc_index PTP hardware clock device to use.

Don't need both just need to fix the previous one :) There's only one parameter.

Post by Jacob Keller
- * Pass NULL to select CLOCK_REALTIME.
+ * Pass -1 to select CLOCK_REALTIME.
*/
-struct clock *clock_create(char *phc, struct interface *iface, int count,
+struct clock *clock_create(int phc_index, struct interface *iface,
+int count,
struct defaultDS *ds, struct port_defaults *pod);
/**
diff --git a/port.c b/port.c
index ebcc7bb..1ef2fca 100644
--- a/port.c
+++ b/port.c
@@ -33,6 +33,7 @@
#include "tmtab.h"
#include "tmv.h"
#include "util.h"
+#include "sk.h"
#define PORT_MAVE_LENGTH 10
@@ -1328,6 +1329,7 @@ enum fsm_event port_event(struct port *p, int
fd_index) }
struct port *port_open(struct port_defaults *pod,
+ int phc_index,
char *name,
enum transport_type transport,
struct port *port_open(struct port_defaults *pod,
struct clock *clock)
{
struct port *p = malloc(sizeof(*p));
+ int checked_phc_index = -1;
+
if (!p)
return NULL;
memset(p, 0, sizeof(*p));
+ if (sk_interface_phc(name, &checked_phc_index))
+ pr_warning("get_ts_info operation not supported");

pr_warning("port %d: get_ts_info operation not supported",
number);

Yes that makes sense :)

Post by Jacob Keller
+ else if ((phc_index >= 0) && (phc_index != checked_phc_index)) {

Too many parentheses here.

Oops. Was being overly careful without thinking about whether they were needed.

Post by Jacob Keller
+ pr_err("requested and expected phc devices don't match");
+ pr_err("/dev/ptp%d requested, but /dev/ptp%d expected",
+ phc_index, checked_phc_index);

To me, saying 'expected' is confusing. How about this instead?
else if (phc_index >= 0 && phc_index != checked_phc_index) {
pr_err("port %d: PHC device mismatch", number);
pr_err("port %d: /dev/ptp%d requested, but /dev/ptp%d is
attached",
number, phc_index, checked_phc_index);

Yes, I didn't like expect but couldn't think of anything better.

Post by Jacob Keller
+ return NULL;
+ }
+
p->pod = *pod;
p->name = name;
p->clock = clock;
diff --git a/port.h b/port.h
index 6f02b73..7ecd893 100644
--- a/port.h
+++ b/port.h
@@ -89,6 +89,7 @@ enum fsm_event port_event(struct port *port, int

fd_index);

Post by Jacob Keller
*/
struct port *port_open(struct port_defaults *pod,
+ int phc_index,

This new parameter should also be added to the doxygen comment.

Yep. :)

Post by Jacob Keller
char *name,
enum transport_type transport,
enum timestamp_type timestamping, diff --git a/ptp4l.c
b/ptp4l.c index cbf0d7e..b645636 100644
--- a/ptp4l.c
+++ b/ptp4l.c
@@ -77,23 +77,24 @@ static void usage(char *progname)
" (may be specified multiple times)\n"
" -l [num] set the logging level to 'num'\n"
" -m slave only mode (overrides configuration file)\n"
- " -p [dev] PTP hardware clock device to use, default '%s'\n"
+ " -p [dev] PTP hardware clock device to use, default auto\n"
" (ignored for SOFTWARE/LEGACY HW time stamping)\n"
" -q quiet mode, do not use syslog(3)\n"
" -v verbose mode, print messages to stdout\n"
"\n",
- progname, DEFAULT_PHC);
+ progname);
}
int main(int argc, char *argv[])
{
- char *config = NULL, *phc = DEFAULT_PHC, *progname;
+ char *config = NULL, *req_phc = NULL, *progname;
int c, i, nports = 0, slaveonly = 0;
struct interface iface[MAX_PORTS];
enum delay_mechanism dm = DM_E2E;
enum transport_type transport = TRANS_UDP_IPV4;
enum timestamp_type timestamping = TS_HARDWARE;
struct clock *clock;
+ int phc_index = -1;
/* Process the command line arguments. */
progname = strrchr(argv[0], '/');
@@ -139,7 +140,7 @@ int main(int argc, char *argv[])
dm = DM_P2P;
break;
- phc = optarg;
+ req_phc = optarg;
break;
print_no_syslog();
@@ -176,8 +177,21 @@ int main(int argc, char *argv[])
for (i = 0; i < nports; i++) {
iface[i].timestamping = timestamping;
}
+
+ /* determine PHC Clock index */
if (timestamping == TS_SOFTWARE || timestamping == TS_LEGACY_HW) {
- phc = NULL;
+ phc_index = -1;
+ } else if (req_phc) {
+ sscanf(req_phc, "/dev/ptp%d", &phc_index);

if (1 != sscanf(req_phc, "/dev/ptp%d", &phc_index)) {
fprintf(stderr, "bad device string\n");
return -1;
}

Alright. Makes sense to have that :)

Post by Jacob Keller
+ } else if (sk_interface_phc(iface[0].name, &phc_index)) {
+ fprintf(stderr, "get_ts_info operation not supported\n"
+ "please specify PHC device\n");
+ return -1;
+ }
+
+ if (phc_index >= 0) {
+ fprintf(stderr, "selected /dev/ptp%d as PHC clock\n",
+ phc_index);

This isn't really an error message. Please remove this. Instead, how about a
similar message telling the PHC index and network device in
sk_interface_phc(), and using use pr_info so that the message goes into the
log.

We don't want this in sk_interface_phc because that gets called again later,
I assumed we wouldn't want that printed out twice. I can add it there if you want.
Or I could use pr_info here?

Post by Jacob Keller
}
ds.slaveOnly = FALSE;
@@ -213,7 +227,7 @@ int main(int argc, char *argv[])
ds.clockQuality.clockClass = 255;
}
- clock = clock_create(phc, iface, nports, &ds, &pod);
+ clock = clock_create(phc_index, iface, nports, &ds, &pod);
if (!clock) {
fprintf(stderr, "failed to create a clock\n");
return -1;
diff --git a/sk.c b/sk.c
index 810d036..e7d2fbe 100644
--- a/sk.c
+++ b/sk.c
@@ -20,6 +20,7 @@
#include <errno.h>
#include <linux/net_tstamp.h>
#include <linux/sockios.h>
+#include <linux/ethtool.h>
#include <net/if.h>
#include <netinet/in.h>
#include <string.h>
@@ -29,6 +30,10 @@
#include "print.h"
#include "sk.h"
+#ifndef SIOCETHTOOL
+#define SIOCETHTOOL 0x8946
+#endif
+

I don't think this is needed. Why did you add it?

It didn't compile for me without it. Might be a header mismatch?
I don't think it hurts anything?

Post by Jacob Keller
/* private methods */
sk_interface_index(int fd, char *name)
return ifreq.ifr_ifindex;
}
+int sk_interface_phc(char *name, int *index) {

This function will not compile using an older (eg 3.0 or 3.1) kernel.
#ifdef ETHTOOL_GET_TS_INFO
...
#else
return -1;
#endif

Ah, yes.

Post by Jacob Keller
+ struct ethtool_ts_info info;
+ struct ifreq ifr;
+ int fd, err;
+
+ memset(&ifr, 0, sizeof(ifr));
+ memset(&info, 0, sizeof(info));
+ info.cmd = ETHTOOL_GET_TS_INFO;
+ strcpy(ifr.ifr_name, name);
+ ifr.ifr_data = &info;

Need a cast to make gcc 4.4.6 happy.
ifr.ifr_data = (char *) &info;
Thanks,
Richard

Lots of good minor changes. I will send a version 2 in a few minutes :)