[Linuxptp-devel] [PATCH] Allow received GET management messages to have bodies

[Geoff Salmon]

You'd probably expect the body of GET messages to be empty, but
interpretation #29 in
http://standards.ieee.org/findstds/interps/1588-2008.html implies
otherwise. With this change, ptp4l will respond to GETs containing
either an empty dataField or a dataField whose length matches the
managementId. If present, the contents of the dataField are ignored.

Signed-off-by: Geoff Salmon <***@se-instruments.com>
---
clock.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/clock.c b/clock.c
index 0353b5a..aace086 100644
--- a/clock.c
+++ b/clock.c
@@ -792,10 +792,6 @@ void clock_manage(struct clock *c, struct port *p, struct ptp_message *msg)
*/
switch (management_action(msg)) {
case GET:
- if (mgt->length != 2) {
- clock_management_send_error(p, msg, WRONG_LENGTH);
- return;
- }
if (clock_management_get_response(c, p, mgt->id, msg))
return;
break;

[Richard Cochran]

Post by Geoff Salmon
You'd probably expect the body of GET messages to be empty, but
interpretation #29 in
http://standards.ieee.org/findstds/interps/1588-2008.html implies
otherwise. With this change, ptp4l will respond to GETs containing
either an empty dataField or a dataField whose length matches the
managementId. If present, the contents of the dataField are ignored.
---

Applied.

Thanks,
Richard