[Linuxptp-devel] ClockType bit definitions are incorrect

[Dale Smith]

The 1588 errata/clarifications at
http://standards.ieee.org/findstds/interps/1588-2008.html Response #8
clarifies where the bits are in the 2 byte clock type.

I think linuxptp currently is doing this incorrectly. Wireshark agrees.

All that's needed is to change the clock_type enum values to something like
this:

enum clock_type {
CLOCK_TYPE_ORDINARY = 0x8000,
CLOCK_TYPE_BOUNDARY = 0x4000,
CLOCK_TYPE_P2P = 0x2000,
CLOCK_TYPE_E2E = 0x1000,
CLOCK_TYPE_MANAGEMENT = 0x0800,
};

-Dale

[Richard Cochran]

Post by Dale Smith
All that's needed is to change the clock_type enum values to something like
enum clock_type {
CLOCK_TYPE_ORDINARY = 0x8000,
CLOCK_TYPE_BOUNDARY = 0x4000,
CLOCK_TYPE_P2P = 0x2000,
CLOCK_TYPE_E2E = 0x1000,
CLOCK_TYPE_MANAGEMENT = 0x0800,
};

Care to submit a patch with a short description and SOB?

Thanks,
Richard

[Dale P. Smith]

Sure. What's a SOB?

-Dale

Post by Richard Cochran
Care to submit a patch with a short description and SOB?